snapshots: index builder refactorings #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battlmonstr
force-pushed
the
pr/index_refac
branch
5 times, most recently
from
a3f1e8f
to
b2191a7
Compare
battlmonstr
changed the title
battlmonstr
force-pushed
the
pr/index_refac
branch
2 times, most recently
from
abd5ca0
to
f05bc28
Compare
battlmonstr
force-pushed
the
pr/index_refac
branch
from
f05bc28
to
ffd147c
Compare
canepat
approved these changes
Mar 26, 2024
| index.build(); | ||
| break; | ||
| } | ||
| case SnapshotType::transactions: { | ||
| TransactionIndex index{*snap_file}; | ||
| auto bodies_segment_path = TransactionIndex::bodies_segment_path(*snap_file); | ||
| auto index = TransactionIndex::make(bodies_segment_path, *snap_file); |
There was a problem hiding this comment.
You could merge these two lines into just one:
auto index = TransactionIndex::make(*snap_file);
looking exactly similar to the HeaderIndex and BodyIndex above, either by refactoring or overloading the current TransactionIndex::make. Next PR is fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same IndexBuilder is used for all indexes. It needs a descriptor (with settings) and a query (with input data). There are 2 types of index input data queries:
Each target index is configured in its own dedicated file. TransactionToBlockIndex is separated from the TransactionIndex.
Transaction indexes require a bodies_segment_path to be provided. capi also passes a bodies_segment_region.
Avoid get_os_temporary_path in tests: the tests were interfering with each other.