Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcdaemon: fix trace state diff with CREATE and SELFDESTRUCT #2278

Merged
merged 5 commits into from
Aug 30, 2024
Merged

rpcdaemon: fix trace state diff with CREATE and SELFDESTRUCT #2278

merged 5 commits into from
Aug 30, 2024

Conversation

lupin012
Copy link
Contributor

No description provided.

canepat
canepat requested changes Aug 29, 2024
View reviewed changes
silkworm/core/state/intra_block_state.hpp Outdated Show resolved Hide resolved
silkworm/core/state/intra_block_state.cpp Outdated Show resolved Hide resolved
silkworm/rpc/core/evm_trace.cpp Outdated Show resolved Hide resolved
silkworm/rpc/core/evm_trace.cpp Outdated Show resolved Hide resolved
chfast
chfast reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@chfast chfast left a comment •
edited by lupin012
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any kind of regression tests for such changes?

@lupin012 lupin012 force-pushed the StateDiff_fix_CREATE_SELFDESTRUCT branch from 9fdb1ba to 14e48cf Compare August 30, 2024 05:51
@lupin012 lupin012 marked this pull request as ready for review August 30, 2024 06:01
@lupin012 lupin012 requested a review from canepat August 30, 2024 06:02
@lupin012 lupin012 added the maintenance Some maintenance work (fix, refactor, rename, test...) label Aug 30, 2024
@lupin012
Copy link
Contributor Author

Do you have any kind of regression tests for such changes?

Yes I have some new rpc-integration-tests cover this scenarios and I have many other rpc-integration-tests ("to try") to avoid regression.
These changes are related only tracer implementation (to be more aligned to erigon/rpcdaemon), the change on intra-block-state are just a getter.

@canepat canepat changed the title rpcdaemon: fix stateDiff with CREATE and SELFDESTRUCT rpcdaemon: fix trace state diff with CREATE and SELFDESTRUCT Aug 30, 2024
@canepat canepat merged commit 29ad14e into master Aug 30, 2024
5 checks passed
@canepat canepat deleted the StateDiff_fix_CREATE_SELFDESTRUCT branch August 30, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast left review comments

@canepat canepat canepat approved these changes

Assignees
No one assigned
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lupin012 @chfast @canepat @web-flow