Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcdaemon: new gas bailout handling #2322

Merged
merged 2 commits into from
Sep 9, 2024
Merged

rpcdaemon: new gas bailout handling #2322

merged 2 commits into from
Sep 9, 2024

Conversation

lupin012
Copy link
Contributor

@lupin012 lupin012 commented Sep 7, 2024 •
edited by canepat
Loading

This PR contains:

  • gas bailout disabled in trace_get and trace_transaction
  • if gas bailout is enabled, do not subtract gas cost and do not refund gas in bailout-enabled trace API

Details
These changes required to mark as touched in IntraBlockState any address having code or nonce changed w/o any balance change.

@lupin012 lupin012 added the maintenance Some maintenance work (fix, refactor, rename, test...) label Sep 7, 2024
@canepat canepat marked this pull request as ready for review September 9, 2024 12:15
@canepat canepat self-requested a review September 9, 2024 12:15
@canepat canepat changed the title rpcdaemon: new gas_bailout mgt rpcdaemon: new gas bailout handling Sep 9, 2024
@canepat canepat merged commit 05a6ab8 into master Sep 9, 2024
5 checks passed
@canepat canepat deleted the new_gas_bailout_mgt_for_trace_call_and_trace_callMany branch September 9, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canepat canepat canepat approved these changes

Assignees
No one assigned
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lupin012 @canepat