db: add BTree index for kv snapshots #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canepat
added
snapshots
canepat
requested review from
JacekGlen,
battlmonstr,
Sixtysixter,
bzawisto and
lupin012
bzawisto
reviewed
Sep 23, 2024
battlmonstr
approved these changes
Sep 23, 2024
| //! - if found item.key has \p seek_key as prefix, return found=false and item.key | ||
| //! - if key is greater than all keys, return found=false and empty key | ||
| //! \endverbatim | ||
| SeekResult seek(ByteView seek_key, DataIterator& data_it); |
There was a problem hiding this comment.
is it possible to put DataIterator in SeekResult here and same in get()?
There was a problem hiding this comment.
No, it is not because it's not a pure output parameter: it's an input parameter that gets modified by the function call (i.e. the iterator gets moved).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for reading B+Tree index files (
.bt) associated to Erigon3 key-value state snapshots (.kv).Related changes:
bitmask_operatorsfromRecSplitand move into common placeseg::Decompressorto support files w/ key-value compression combinationsopen_btree_indexsubcommand insnapshotscommand-line utility