Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db: provide SnapshotRepository to DataModel #2440

Merged
merged 2 commits into from
Oct 25, 2024
Merged

db: provide SnapshotRepository to DataModel #2440

merged 2 commits into from
Oct 25, 2024

Conversation

battlmonstr
Copy link
Contributor

@battlmonstr battlmonstr commented Oct 22, 2024 •
edited
Loading

  • no more DataModel::set_snapshot_repository singleton
  • BodyFindByBlockNumMultiQuery: useful without RoTx
  • DataStoreRef: source of creating DataModel queries for kv::api, sync and daemon
  • db::Buffer works with BufferDataModel (useful to decouple tests from snapshots)
  • ExecutionPipeline accepts StageContainerFactory
  • stages and forks use DataModelFactory
  • SnapshotRepository: init with path instead of settings

@battlmonstr battlmonstr added the snapshots Framework for BitTorrent-based snapshots label Oct 22, 2024
@canepat canepat mentioned this pull request Oct 22, 2024
Open
41 tasks
@battlmonstr battlmonstr force-pushed the pr/reposingleton branch 8 times, most recently from 3d7994d to 709d904 Compare October 23, 2024 15:04
@battlmonstr battlmonstr marked this pull request as ready for review October 23, 2024 15:06
@battlmonstr battlmonstr requested a review from canepat October 23, 2024 15:06
@battlmonstr battlmonstr enabled auto-merge (squash) October 23, 2024 15:08
@battlmonstr
db: provide SnapshotRepository to DataModel
7f073f1 
* no more DataModel::set_snapshot_repository singleton
* BodyFindByBlockNumMultiQuery: useful without RoTx
* DataStoreRef: source of creating DataModel queries for kv::api, sync and daemon
* Buffer works with BufferDataModel
* ExecutionPipeline accepts StageContainerFactory
* stages and forks use DataModelFactory
* SnapshotRepository: init with path instead of settings
@canepat canepat added the erigon3 Erigon3 feature label Oct 25, 2024
@battlmonstr battlmonstr merged commit 213f140 into master Oct 25, 2024
5 checks passed
@battlmonstr battlmonstr deleted the pr/reposingleton branch October 25, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canepat canepat canepat approved these changes

Assignees
No one assigned
Labels
erigon3 Erigon3 feature snapshots Framework for BitTorrent-based snapshots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@battlmonstr @canepat