datastore: DataStore and related refactorings #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battlmonstr
added
snapshots
battlmonstr
force-pushed
the
pr/data_store1
branch
8 times, most recently
from
9e526ba to
88112f4
Compare
battlmonstr
changed the title
battlmonstr
force-pushed
the
pr/data_store1
branch
2 times, most recently
from
723c579 to
0fe6a7f
Compare
battlmonstr
force-pushed
the
pr/data_store1
branch
from
e7395cd to
a42e3a6
Compare
battlmonstr
force-pushed
the
pr/data_store1
branch
from
a42e3a6 to
823e067
Compare
see #2479 also: use CLion's clang-tidy on macOS It requires "builtin includes" located at "../lib/clang/19/include"
battlmonstr
force-pushed
the
pr/data_store1
branch
from
823e067 to
7a5e465
Compare
canepat
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datastore::DataStoreis a root database (mdbx + snapshots) object. It owns chaindata and snapshot repository instances. It supports multiple snapshot repositories named uniquely with anEntityName.db::DataStorewrapsdatastore::DataStoreon the DAL side and provides a convenience constructor and access via DataStoreRef. It usesdb::blocks::make_blocks_repositoryto create a SnapshotRepository of "block" snapshots.Related refactorings:
make_repository()with TestDataStore subclass of TestDatabaseContext, and TempChainDataStore subclass of TempChainDatamdbx::open_env()config const (the page_size update within NodeSettings is unused)