Use evmone APIv2 - initial integration #2480
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2024
Closed
Add support for Ethereum Execution Spec Tests (EEST) fixtures
(archives of generated JSON tests). In EEST fixtures blockchain tests
are placed in `blockchain_tests` subdirectory so register it for the
blockchain test runner.
Usage is:
cmd/test/ethereum --tests path/to/fixtures
Example EEST release:
https://github.com/ethereum/execution-spec-tests/releases/tag/v3.0.0
This reverts commit 1c8b50c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate evmone's higher level API for transaction execution.
The new API moves the level of granularity of EVM execution from internal calls to whole transaction. This hides a lot of EVM details from the user (Silkworm), e.g. transient storage, internal calls logic, worm/cold accesses, state revert journal.
evmone API
The API itself is "work in progress", but the goal is to improve it on both sides going into the future. The current best indicator how well it is defined are the additional evmone files added to the compilation of Silkworm. We also use the side branch with some shortcoming on top of the evmone's main branch. The plan is to integrate these changes to evmone over time. Therefore, the length of the branch is good indicator how much more is left to be done.
Performance
I did a performance test of historical block execution up to block 15M on Mainnet. This was used to motivate changes in evmone by eliminating obvious overhead (e.g. transaction should not be validated in evmone, evmone should not compute log's bloom filters). The final result was the sync time was the same (within 1%).