Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously SnapshotBundle contained a fixed number of predefined entities.
Now SnapshotBundle is dynamic and based on a
snapshots::Schema::RepositoryDef
. The actual schema is defined indb::blocks::make_blocks_repository_schema()
.snapshots::Schema
follows a "fluent config builder" pattern. Currently rec_split_index_defs_ values are trivial there, but in the future we will configure index builders there.snapshots::Schema::RepositoryDef is a part of datastore::Schema. It is configured by db::DataStore::make_schema.
Currently datastore::Schema just wraps snapshots::Schema, but in the future it will also contain DHIIs.
For the DAL client code a db::blocks::BundleDataRef wrapper is provided for convenient access into the block repository bundles (much like db::DataStoreRef provides a convenient access to the block repository).
Related refactorings:
repository