Update loader-utils. #21
Conversation
| var filename = options.name || path.basename(this.resourcePath); | ||
| var context = options.context || this.rootContext; | ||
| var name = options.name || path.basename(this.resourcePath); | ||
| var filename = loaderUtils.interpolateName(this, name, { context: context }); |
There was a problem hiding this comment.
I'm unsure about this change; I used to use interpolateName but I removed it in v6.
Although it's been so long that I don't quite remember why...in the release notes I said "...[hash] is correctly updated when subresources change..." but this PR didn't break the hashes in the tests, so maybe it's fine? OTOH maybe I meant "when subresources change during watch builds" which isn't tested.
Thoughts?
There was a problem hiding this comment.
@erikdesjardins Haven't noticed any problems in watch mode with my PR.
The reason I re-added interpolateName (and updated loader-utils) is because this allows for options.name to be a function returning a placeholder string. Passing this function as filename option directly to this._compilation.createChildCompiler doesn't work, so that's why I'm interpolating it before passing to the child compiler.
|
Released in v7 |
|
Awesome, thank you! |
This Pull Request:
context(defaults torootContext- the directory of the module).