Use resource path when adding dependency. #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request:
addDependency
, rather than the provided remainingrequest
.Why is this PR needed?
The
request
variable is in the inline loader format, and contains the remaining loaders. For example, if you're usingbabel-loader
on your script files, thenrequest = "/path/to/project/node_modules/babel-loader/lib/index.js!/path/to/project/scripts/main.js"
.This breaks watch mode, as
addDependency
expects the absolute path to the dependency itself, not including any loaders. Therefore, this PR usesthis.resourcePath
.Things to Note
I think this might be a Webpack 5 only issue (this loader was working fine in Webpack 4 for me).