Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set attributes to LocalPrint as if we wrapped print. #30

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Conversation

eriknw
Copy link
Owner

@eriknw eriknw commented Sep 30, 2021

Fixes #29 (probably). This was a quick and easy fix, so let's see how far it takes us.

@jcrist's suggestion to instead monkey-patch sys.stdout (and sys.stderr) is a good idea, and we may want to give it a try too.

@ncclementi I plan to merge this and release afar. This fixes the bug you reported, so hopefully things will "just work" after this 🤞

Fixes #29 (probably).  This was a quick and easy fix, so let's see how far it takes us.

@jcrist's suggestion to instead monkey-patch `sys.stdout` (and `sys.stderr`)
is a good idea, and we may want to give it a try too.
@eriknw eriknw merged commit b5eb31f into main Sep 30, 2021
@eriknw eriknw deleted the wrap_print branch September 30, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Afar not working with cudf/dask-cudf/gpu-numba
1 participant