Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(1) leave pep8 and flake8 up to prospector, not pytest #90

Merged

Conversation

jquast
Copy link
Collaborator

@jquast jquast commented Feb 28, 2015

We disable the --pep8 and --flakes arguments for py.test, leaving static analysis up to 'prospector', with the intent to disable the "ignore exit code" currently used (which is indicated by prefixing the 'prospector' command with a hyphen).

Please note that the TeamCity builds fail until acceptance of PR #91.

NOTE: this branch to be merged into PR #89, PR #88, PR #87, PR #86, PR #90 so that their passing tests may be assured.

We disable the --pep8 and --flakes arguments for py.test,
leaving static analysis up to 'prospector', with the intent
to disable the "ignore exit code" currently used (which is
indicated by prefixing the 'prospector' command with a hyphen).
@jquast jquast changed the title leave pep8 and flake8 up to prospector, not pytest (1) leave pep8 and flake8 up to prospector, not pytest Mar 3, 2015
@erikrose
Copy link
Owner

erikrose commented Mar 5, 2015

Fine with me. Honestly, I don't care much about tooling beyond testrunners.

erikrose added a commit that referenced this pull request Mar 5, 2015
…o-prospector

(1) leave pep8 and flake8 up to prospector, not pytest
@erikrose erikrose merged commit 7360504 into blessed-integration Mar 5, 2015
@jquast jquast deleted the blessed-integration-leave-pep8-to-prospector branch March 8, 2015 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants