Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

falseproofing AVX2 for ARM64 arch by explicitly stating it #141

Closed
demolen opened this issue Mar 30, 2024 · 0 comments · Fixed by #149
Closed

falseproofing AVX2 for ARM64 arch by explicitly stating it #141

demolen opened this issue Mar 30, 2024 · 0 comments · Fixed by #149

Comments

@demolen
Copy link

demolen commented Mar 30, 2024

in Cmakelists:

option (BOX2D_AVX2 "Enable AVX2 (faster)" ON)

could be replaced with:

if (CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|AMD64")
option (BOX2D_AVX2 "Enable AVX2 (faster)" ON)
else()
option (BOX2D_AVX2 "Enable AVX2 (faster)" OFF)
endif()
@erincatto erincatto mentioned this issue Apr 25, 2024
Merged
erincatto added a commit that referenced this issue Apr 25, 2024
@erincatto
more sanitizing (#149)
e2504c7 
- more sanitizer usage, delayed by an enkiTS issue:
dougbinks/enkiTS#125
- fix #145
- address #144
- fix #141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

more sanitizing erincatto/box2c
1 participant
@demolen