Continue drop q #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes unnecesary Promise wrapping in onFulfilled callback.
The important thing is that we always handle rejections.
The exception being ProjectBuilder.spec where we need to create stubs of `superspawn.spawn` for a function that uses the returned Q instance's `progress` method. Working around this makes little sense with the transistion to `execa` already in progress. Requires Jasmine 3.5
We should just get rid of that using execa
erisu
reviewed
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of apache#833
Fixes a few things in your PR and completes the removal except for the cases where we need to switch to
execafirst.