Support for additional scale and fixes according to the docs. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dymo M25 Scale uses different endpoint from the default (LIBUSB_RECIPIENT_ENDPOINT instead of LIBUSB_RECIPIENT_INTERFACE), hence we need to find it in the device's configuration.
erjiang
added a commit
that referenced
this pull request
Oct 26, 2015
Support for additional scale, fix weight calculation
|
Hi @sanmai, I tested your changes and you are right about the weight calculation. Thanks for fixing this issue! I unfortunately do not have many scales to test with so I didn't notice this error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the docs we read that a numeric value representing the scaling applied to the data as ten exponent base. In other words exponent value shall be signed.
Dividing by 10 as it was on line 280 would only work for ounces. For example, DYMO M25 when set to work in grams would return them as they are, and dividing by ten would give us invalid value.
I believe this should bring #8 to closing.