feat(wip): support specific auth method validation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erka
reviewed
Dec 9, 2023
|
It looks good to me |
…triping session domain
Uffizzi Ephemeral Environment
|
|
Looks great. My phone is not letting me add a review, but it’s a thumbs up from me. |
|
@erka do you want to merge this into your branch/pr then we can merge that into main? |
erka
added a commit
that referenced
this pull request
Dec 11, 2023
…-io#2508) * feat(auth/github): add organization membership check to GitHub authentication method fixes flipt-io#2065 * rename configuration option * cleanup * cleanup * improve code test coverage * Update internal/config/authentication.go Co-authored-by: Mark Phelps <209477+markphelps@users.noreply.github.com> * address PR review feedback * cleanup * feat: support specific auth method validation (#4) --------- Co-authored-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@erka , I think this might work to validate that they have the required
read:orgscopes if they haveallowed_organizationsrequiredre: flipt-io#2508 (comment)
This is still WIP as I need to add some tests, but wanted to unblock you and get yours and @GeorgeMac 's thoughts