Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user background job for hover provider to avoid blocking request queue #1091

Merged
merged 3 commits into from
Sep 27, 2021

Conversation

TheGeorge
Copy link
Contributor

Description

When cmd+click on a function (or similar) in a large document, the client might produce the following requests:

  • hover request (when having the mouse over the element)
  • cancel request (when clicking)
  • definitions request

The hover request can take several seconds, and is synchronous currently. All actions that follow the hover request are stalled until it is served. This change uses background jobs for hover instead, which makes them cancellable and provides lower latencies for follow-up requests, e.g. definitions.

@robertoaloi robertoaloi merged commit 8939837 into erlang-ls:main Sep 27, 2021
@robertoaloi
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants