beam_ssa_opt: Fix block tracking in bsm_shortcut #10048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhogberg
added
team:VM
CT Test Results 2 files 324 suites 9m 27s ⏱️ Results for commit b7f18fb. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
potatosalad
added a commit
to WhatsApp/erlang-argo
that referenced
this pull request
Jul 15, 2025
lucioleKi
previously approved these changes
Jul 16, 2025
jhogberg
force-pushed
the
john/compiler/fix-bsm-shortcut/GH-10047/OTP-19711
branch
from
2b2e5df to
a1d8cc1
Compare
Success blocks were not adequately tracked, causing `bs_test_tail` instructions to be removed when they shouldn't have been. Fixes erlangGH-10047
jhogberg
force-pushed
the
john/compiler/fix-bsm-shortcut/GH-10047/OTP-19711
branch
from
a1d8cc1 to
b7f18fb
Compare
lucioleKi
approved these changes
Jul 17, 2025
potatosalad
added a commit
to WhatsApp/erlang-argo
that referenced
this pull request
Aug 14, 2025
* Enhancements * Add support for `argo_value:from_erlang/2` and `argo_value:to_erlang/1` for term-based conversion. * Fixes * Workaround for compiler bug in `argo_varbit` related to [erlang/otp#10048](erlang/otp#10048)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Success blocks were not adequately tracked, causing
bs_test_tailinstructions to be removed when they shouldn't have been.Fixes GH-10047