Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove macOS version check (maint-22) #4523

Closed
wants to merge 1 commit into from

Conversation

gromgit
Copy link

@gromgit gromgit commented Feb 16, 2021

Backport d827997 to enable Homebrew builds on Big Sur.

Addresses Homebrew/homebrew-core#71268.

Backport erlang@d827997 to enable Homebrew builds on Big Sur.

Addresses Homebrew/homebrew-core#71268.
@CLAassistant
Copy link

CLAassistant commented Feb 16, 2021

CLA assistant check
All committers have signed the CLA.

@rickard-green rickard-green added the team:VM Assigned to OTP team VM label Feb 17, 2021
@bjorng
Copy link
Contributor

bjorng commented Feb 17, 2021

We usually don't release patches to make older OTP releases work on recent OS releases, but we will make an exception in this case.

We plan to release a patch that also includes back ports of the following important pull requests: #2768 and #2708.

Does anyone remember whether there any other important bug fixes for macOS that should be included in that patch?

@gromgit
Copy link
Author

gromgit commented Feb 17, 2021

Thanks much, @bjorng!

Does anyone remember whether there any other important bug fixes for macOS that should be included in that patch?

Just FYI, Homebrew has also been quietly applying #2687 (a.k.a. ERL-1306) to fix maint-21 and maint-22 Xcode 12+ configure failures on Big Sur (and I think Catalina as well) for some time now. Would be good to have that backported too. Thanks again!

@bjorng
Copy link
Contributor

bjorng commented Feb 18, 2021

Just FYI, Homebrew has also been quietly applying #2687

Yes, my branch didn't build so I found and cherry-picked that one too. So far my branch has four commits. We will do some more testing and then we will add the branch to the queue of patches to be released. Here is my branch:

https://github.com/bjorng/otp/tree/bjorn/macos11-otp22%2FOTP-16779

@rickard-green
Copy link
Contributor

Fixed in the just released OTP 22.3.4.16 patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants