Add option to discard whitespace before xml tag #9753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 24 suites 8m 1s ⏱️ Results for commit 63e6d3e. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
reviewed
Apr 22, 2025
| @@ -0,0 +1,16 @@ | |||
|
|
|||
| Unknown functions: | |||
There was a problem hiding this comment.
Was this file meant to be added?
There was a problem hiding this comment.
No, hmm wonder how I got that in. Always add files manually :).
garazdawi
reviewed
Apr 22, 2025
| @@ -0,0 +1,38 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
Please add a license header o this file.
lthor
force-pushed
the
lars/discard-space-before-xml-tag-27/OTP-19602
branch
2 times, most recently
from
c6ec2a0 to
8541180
Compare
dgud
previously approved these changes
Apr 28, 2025
Add an option to discard whitespace before the xml tag when reading from a stream. Also updated a bad error message.
lthor
force-pushed
the
lars/discard-space-before-xml-tag-27/OTP-19602
branch
from
8541180 to
63e6d3e
Compare
dgud
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to discard whitespace before the xml tag when reading from a stream.
Also updated a bad error message.