Various fixes related to .app files #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ferd
commented
Oct 4, 2017
ferd
commented
- Add a description in compiled app file if undefined. Same default value as used in relx and other environments, but as reported in Generate default description if missing in *.app.src #979 some tools don't like having no description available.
- The parsing functions in app_details were used inconsistently, and the returned values were bad in some clauses; things only worked because they are never used within rebar3. This ensures the return types are consistent on all clauses.
- bundling in quickfixes (rollback to git versionning -- I bad messed up a commit) and test patch to find nondeterministic data.
was still hardcoded to 3.4.4
The parsing functions were used inconsistently, and the returned values were bad in some clauses; things only worked because they are never used within rebar3. This ensures the return types are consistent on all clauses.
Same default value as used in relx and other environments, but as reported in erlang#979 some tools don't like having no description available.
Getting real tired of that nondeterministic set of runs on OSX CI
tsloughter
approved these changes
Oct 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.