Make rebar3 work with dialyzer internally #1750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got funny interactions since PR #1656:
debug_info
-related option seen in a list of options afterprofile merge is kept, allowing later profiles from overtaking earlier
ones
rebar3 as a,b,c compile
, the options from profile A comebefore B, which come before C, so C's options win
to a later profile than an earlier one
existing list
default
adding
no_debug_info', and
dialyzeadding
debug_info, the results are
[debug_info]as
dialyzeis applied first, and then
[no_debug_info, debug_info]as
default` overrides are appliedno_debug_info
always winning when erl_opts areoverriden specifically.
only
debug_info
options are going to suffer this, and in the context ofoverrides. Other
erl_opts
should be fine. I'm not sure how that can befixed at all.
In the meanwhile, we can add support back while leaving the default to
not having debug information. This is done by:
no_debug_info
options to theprod
profileprod
to be called by./bootstrap
so that most people keepgetting no debug info
rebar3 clean -a
and then rebuilding withrebar3 escriptize
(i.e. rebar3 devs) get debug info goingThis is up for review and discussion. Context at #1749