Respect REBAR_GLOBAL_CONFIG_DIR on global_config/0

[elbrujohalcon]

If I'm on a folder without a rebar.config file and I run the following command…

$ REBAR_GLOBAL_CONFIG_DIR=/my/path DIAGNOSTIC=1 rebar3 help

…I would like rebar3 to pick up the plugins I have configured in /my/path/rebar.config and not the ones in ~/.config/rebar3/rebar.config.

[ferd]

Hm, I'm not sure. This is the call for the default value. The actual config dir to use is requiring the State variable:

rebar3/src/rebar_dir.erl

Lines 136 to 159 in d4f52f4

	%% @doc returns the directory where the global configuration files for rebar3
	%% may be stored.
	-spec global_config_dir(rebar_state:t()) -> file:filename_all().
	global_config_dir(State) ->
	filename:join([rebar_config_dir(State), ".config", "rebar3"]).
	rebar_config_dir(State) ->
	case os:getenv("REBAR_GLOBAL_CONFIG_DIR") of
	false ->
	rebar_state:get(State, global_rebar_dir, home_dir());
	ConfDir ->
	ConfDir
	end.
	%% @doc returns the path of the global rebar.config file
	-spec global_config(rebar_state:t()) -> file:filename_all().
	global_config(State) ->
	filename:join(global_config_dir(State), "rebar.config").
	%% @doc returns the default path of the global rebar.config file
	-spec global_config() -> file:filename_all().
	global_config() ->
	Home = home_dir(),
	filename:join([Home, ".config", "rebar3", "rebar.config"]).

My guess is that the function is correct, but it's not the one you actually want to call.

So I assume there's a bug in

rebar3/src/rebar_prv_plugins.erl

Lines 35 to 36 in d4f52f4

	GlobalConfigFile = rebar_dir:global_config(),
	GlobalConfig = rebar_state:new(rebar_config:consult_file(GlobalConfigFile)),

where the wrong version of the function is being called?

[elbrujohalcon]

Maybe?
I checked the code and found only one call to the /1 version of the function and a bunch of calls to /0… 🤷🏻

[ferd]

Superceded by #2683