-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --eval option to shell
#2728
Conversation
Looks workable. What's the expected behaviour when someone submits gibberish? Is it different or inline with what |
Hey @ferd, good question. At this point, my expected behavior was "crash with whatever error message it happens to produce." Which, right now, looks like this:
with
Which could be made more straigthtforward. If you'd like, I can make these changes sometime in about 2 weeks (traveling for the next few weeks, so won't be doing much by way of this kind of stuff). Whadya think? |
Cleaner error descriptions there would be worth it just to reduce error reports and point towards the issue being in the script being evaluated. It's fine to wait on my end. I'm on vacation as well and doing little OSS. |
Rock on! |
I've updated it to give some better error messages so the user clearly knows it's the bad syntax error:
Valid syntax but the call fails for some reason
The above, but with
No rush on this - enjoy your vacation! |
Thanks for merging! |
Functionality added in this PR: erlang/rebar3#2728
These were added in erlang/rebar3#2728
These were added in erlang/rebar3#2728
These were added in erlang/rebar3#2728
Hey folks,
I'm not sure if there's an equivalent function in rebar3 or not, but I found a need to sort-of re-implement
erl -eval
but for therebar3 shell
command, sorebar3 shell --eval "my_module:my_function()"
.This implementation also works like
erl -eval
in that it supports multiple--eval
arguments.Thoughts?