This repository has been archived by the owner on Sep 22, 2024. It is now read-only.
Prevent ETS node view error when trying to enable/disable ETS tracing on a dead node #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the called epl_tracer (dedicated to one node) is alive when trying to disable ETS tracing on websocket connection close.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It takes some time to clean dead node form a Vizceral graph, so there might be a situation when a user clicks on a node in Vizceral graph and the node is already dead. Click on a node cause ErlangPL try to enable/disable ETS tracing for that node and if it's dead it might be a problem. This PR prevents this kind of errors.