Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gleam versions in README.md #308

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

richard-viney
Copy link
Contributor

Description

Updates the Gleam examples to reference more recent Gleam and OTP versions.

@paulo-ferraz-oliveira
Copy link
Collaborator

Hey. Thanks for the update. Could you do similar in the tests so we're sure what we're proposing works?

@richard-viney
Copy link
Contributor Author

Have added Gleam 1.5.1 to .girhub/workflows/{ubuntu,windows}.yml

@paulo-ferraz-oliveira
Copy link
Collaborator

Thanks for this. I'll run CI and if tests pass this gets merged.

@paulo-ferraz-oliveira
Copy link
Collaborator

Is this something you know how to fix in the test files?

https://github.com/erlef/setup-beam/actions/runs/11771918498/job/32831472245?pr=308#step:12:14

@richard-viney
Copy link
Contributor Author

A possible fix has been pushed, I've tested in locally on Gleam 0.23.

@richard-viney
Copy link
Contributor Author

Have pushed another fix.

It might be reasonable to drop support for Gleam versions < v1. Could be one for the next major version bump?

@paulo-ferraz-oliveira
Copy link
Collaborator

paulo-ferraz-oliveira commented Nov 12, 2024

We could merge this, but then the test project is basically useless. I'll try to generate one. Edit: I'll pull request to your fork.

@paulo-ferraz-oliveira
Copy link
Collaborator

It might be reasonable to drop support for Gleam versions

If by this you mean stop testing, yeah, I think we can. If something comes up we have an issue tracker and maybe it'll get fixed.

@paulo-ferraz-oliveira
Copy link
Collaborator

@richard-viney, I pull requested here, to share the load. I tested in my own fork, and hopefully all tests pass.

Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the pull request I created gets merged, and we re-run CI, I think this'll be good to go.

@richard-viney
Copy link
Contributor Author

Thanks!

Copy link
Member

@starbelly starbelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@starbelly starbelly merged commit 5fa4c5f into erlef:main Nov 13, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants