-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gleam versions in README.md #308
Conversation
Hey. Thanks for the update. Could you do similar in the tests so we're sure what we're proposing works? |
878b0ee
to
0716a3c
Compare
Have added Gleam 1.5.1 to |
Thanks for this. I'll run CI and if tests pass this gets merged. |
Is this something you know how to fix in the test files? |
A possible fix has been pushed, I've tested in locally on Gleam 0.23. |
75edb90
to
8965d97
Compare
Have pushed another fix. It might be reasonable to drop support for Gleam versions < v1. Could be one for the next major version bump? |
We could merge this, but then the test project is basically useless. I'll try to generate one. Edit: I'll pull request to your fork. |
If by this you mean stop testing, yeah, I think we can. If something comes up we have an issue tracker and maybe it'll get fixed. |
@richard-viney, I pull requested here, to share the load. I tested in my own fork, and hopefully all tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the pull request I created gets merged, and we re-run CI, I think this'll be good to go.
a66e772
to
0c5f339
Compare
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Updates the Gleam examples to reference more recent Gleam and OTP versions.