-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Erlang 24 to README and some more info on version matching #45
Add Erlang 24 to README and some more info on version matching #45
Conversation
Maybe add an example using |
Thing is even though it's possible, it's kinda discouraged by the rest of the text: "For best results, we recommend specifying exact Erlang/OTP, Elixir versions, and Let me hear "the others"; we'll figure something out. 😄 (I've brought this issue up in the past stating that we could also have a flag for |
Do you know why it is discouraged? I wondered that already when reading the documentation the first time. |
You usually want strict versions in CI to make it reliable. Otherwise you would automatically upgrade to new versions which can have breaking changes or bugs, this can cause issues if your CI is part of your deployment stack or does other critical things. |
@ericmj Got it. Unless convinced otherwise, I would argue it is a good idea to use "latest" if you are developing a library that other people will use with perhaps newer versions than you tested with to get an early warning (of course, nothing prevents you from testing both a specific and a latest version). |
I agree with Eric (we've touched this subject elsewhere before): CI needs to be repeatable, in most cases. However, if you want to also do CI for e.g. nightly builds, to check if your software is compatible with a new release, this is also a valid use case, and the one where version ranges make the most sense. |
@ericmj, any thoughts on getting rid of the Phoenix bit? I'm not sure why it's there, to start with, but it doesn't seem to fit. |
@eproxus wrote a nice GitHub Gist on how to use the action with cache. Over Slack, he told me he's willing to either incorporate this in the README or create a new (e.g.) EXAMPLE_USAGE.md with basically the same content as the gist (via pull request). We could also just point to it. Thoughts? Edit: oh, this also made me review the whole README and I'll be pushing some minor tweaks soon. |
@paulo-ferraz-oliveira Drop the phoenix part imo. |
Done: 5b6c41f |
Yeah, agreed on the phoenix part. It's not exactly relevant to the project. The phoenix parts are things you need to know for using phoenix and postgres in docker containers in general 👍 |
Cool. I'm squash-merging, then. |
I see there's also a bit on "Authenticating with Postgres in Phoenix" in the README, but I'm not sure it fits there. Should we remove that example?