otp-23 support and new env var ERL_DIST_PORT #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new parts of OTP-23 include setting remote_nodename to undefined when caling for a remote console and using -address in erl_call To support -address and to make epmdless easier the env var ERL_DIST_PORT has been added. This port is used to set the min and max listen port to it and used in -address so that erl_call works for nodes not using epmd.
ferd
reviewed
May 14, 2020
| @@ -271,7 +271,7 @@ relx_rem_sh() { | |||
| # if it is then we must generate a node name to use for the remote node | |||
| if [ "11.0" = "$(printf "%s\n11.0" "${ERTS_VSN}" | sort -V | head -n1)" ] ; then | |||
There was a problem hiding this comment.
Na. It adds 11.0 to the list of versions with the current erts vsn, then sorts and sees if the sorted versions has 11.0 first. If it doesn't that means we are earlier than 11.0 and if it does that means we are at 11.0 or later.
ferd
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new parts of OTP-23 include setting remote_nodename to undefined
when caling for a remote console and using -address in erl_call
To support -address and to make epmdless easier the env var
ERL_DIST_PORT has been added. This port is used to set the
min and max listen port to it and used in -address so that
erl_call works for nodes not using epmd.