move create_RELEASES function to relx #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferd
approved these changes
May 24, 2020
The version in sasl's release_handler module required use of set_cwd to get a result where the application list had the apps as relative to the root of the release -- "./lib/..." -- instead of requiring a newer version of OTP (after getting a new version into OTP) having this small function added to relx until we only support versions with the new release_handler module is not a burden and makes things simpler. Part of why set_cwd is bad is it makes parallel release building not an option because of conflicting changes to cwd.
tsloughter
force-pushed
the
create-releases
branch
from
dca9046 to
52aebcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version in sasl's release_handler module required use of
set_cwd to get a result where the application list had the apps
as relative to the root of the release -- "./lib/..." -- instead
of requiring a newer version of OTP (after getting a new version
into OTP) having this small function added to relx until we only
support versions with the new release_handler module is not a
burden and makes things simpler.
Part of why set_cwd is bad is it makes parallel release building
not an option because of conflicting changes to cwd.