Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for optional_applications in otp24 #898

Merged
merged 1 commit into from
Dec 31, 2021

Conversation

tsloughter
Copy link
Member

Optional applications may or may not also be in the applications
list. They are also only optional for the app that lists them
as optional, unlike an excluded application which is global. So
what is optional for app A may be required by app B and thus
cause a failure if it is not found when building the release.

Optional applications may or may not also be in the applications
list. They are also only optional for the app that lists them
as optional, unlike an excluded application which is global. So
what is optional for app A may be required by app B and thus
cause a failure if it is not found when building the release.
@tsloughter
Copy link
Member Author

Testing on otel_getting_started with grpcbox moved to optional_applications and it is failing to include it. It should be the same as one of the test cases I added so not sure what is going on...

@tsloughter
Copy link
Member Author

Argh, oh right, needs a patch in rebar3 to work.

@tsloughter tsloughter merged commit 1a0f5fe into erlware:master Dec 31, 2021
@tsloughter tsloughter deleted the redo-support-optional-apps branch December 31, 2021 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants