Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let find_cookie_val/2 take #headers{} as input #489

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

avtobiff
Copy link
Collaborator

Gives a friendlier API handling cookie lookup.

Copy link
Collaborator

@vinoski vinoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little issue to fix.

src/yaws_api.erl Outdated
%% if several cookies with the same name are passed fron the browser,
%% only the first match is returned
%%
%% If several cookies with the same name are passed, %% only the first
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this comment to eliminate the extra %% preceding "only the first"

Gives a friendlier API handling cookie lookup.

Signed-off-by: Gustaf Naeser <gnaeser@gmail.com>
@avtobiff avtobiff force-pushed the find_cookie_val-header-record branch from 1ec3639 to 5319620 Compare March 31, 2024 13:25
Copy link
Collaborator

@vinoski vinoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@vinoski vinoski merged commit eb20730 into erlyaws:master Mar 31, 2024
19 checks passed
@avtobiff avtobiff deleted the find_cookie_val-header-record branch April 4, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants