Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromeiql stringifies variables before sending them in a request #7

Closed
bryan-havenly opened this issue Aug 10, 2017 · 4 comments
Closed

Comments

@bryan-havenly
Copy link

This extension is setting variables to a string before the entire request payload is stringified, instead of sending an object which is more standard.

@ermanc ermanc closed this as completed Aug 10, 2017
@ermanc ermanc reopened this Aug 10, 2017
@ermanc
Copy link
Owner

ermanc commented Aug 10, 2017

@bryan-havenly yes, but that's because graphql/graphiql standard used to be that way at the time. see: graphql/graphiql#168

that said, once I update graphiql to latest, variables will be an object payload, not stringified JSON.

@ermanc ermanc closed this as completed Aug 10, 2017
bryan-havenly added a commit to bryan-havenly/ChromeiQL that referenced this issue Aug 10, 2017
bryan-havenly added a commit to bryan-havenly/ChromeiQL that referenced this issue Aug 10, 2017
@bryan-havenly
Copy link
Author

I have a PR to do that right now, if you want to merge it. If you'd prefer to do it as part of a larger update that's fine.

@ermanc
Copy link
Owner

ermanc commented Aug 10, 2017

Thanks for the PR @bryan-havenly. I'll hold on to that for now, since I do have a local version that I've been sitting on for too long. I suspect just getting that out is simpler but I might just merge yours too, if that's not the case.

@bryan-havenly
Copy link
Author

That's fine with me as well. I just always try to submit a PR at the same time as an issue if possible :)

We just started using graphql at my work and so far this extension has been awesome. Thanks for making it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants