-
Notifications
You must be signed in to change notification settings - Fork 272
add rough reconnection support #541
base: master
Are you sure you want to change the base?
Conversation
- this breaks currently when your nickname is already in use and I'm unsure why.
Does slate-irc not hook on nickname in use before receiving |
don't merge this yet - there's a problem: the reconnection spawns exponential numbers of attempts simultaneously at each failed attempt. |
@diddledan What's the status of this? |
stream.end(); | ||
var msg = new Msg({ | ||
type: Msg.Type.ERROR, | ||
text: "Connection error. Reconnecting in 30 seconds." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The timeframe in this message doesn't match the setTimeout below -- maybe extract a variable?
@diddledan Any idea why it spawns exponential reconnection attempts? Does the error-handler fire multiple times per disconnect or something? |
@edbrannin @diddledan I fixed exponential reconnection attempts and added reconnection on ping timeout - will upload working version soon. P.S. "nickname is already in use" problem doesn't occur, already fixed? |
@bews, just to let you know, development on Shout has become inactive, so it's likely that you will not get an answer to your question(s). FYI, the officially supported fork The Lounge has active development around automatic reconnection support, see thelounge/thelounge#254. It's not quite there yet, but almost. I wanted to chime in to avoid duplicating similar work :-) |
@astorije well, when I started working with Shout I didn't know about Lounge fork, so I'll stick with this one :) I've modified a lot of things here, some of them will be uploaded soon. |
Ok then! :-) Just know that the maintainers' team has moved to The Lounge so if you want to contribute, it's more likely that your work will be merged there. |
reference: issue #235