Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Change user buttons to as. Allows highlighting on firefox. #574

Merged
merged 2 commits into from
Jan 26, 2016
Merged

Change user buttons to as. Allows highlighting on firefox. #574

merged 2 commits into from
Jan 26, 2016

Conversation

AlMcKinlay
Copy link
Contributor

No description provided.

@astorije
Copy link
Collaborator

For the record, this comes from #571 (my bad...).

@astorije astorije self-assigned this Jan 11, 2016
@astorije astorije added the bug label Jan 11, 2016
@astorije
Copy link
Collaborator

(Removing my 👍 for now until comment below is addressed)

Another simple fix for another simple bug, thanks @YaManicKill! :-)

@JocelynDelalande, @erming, @floogulinc for a second review?

@xPaw
Copy link
Contributor

xPaw commented Jan 23, 2016

I believe there are some styles that rely on button selector, did you look at these? Ideally they should be changed to .user

@astorije
Copy link
Collaborator

Good point! @YaManicKill, could you take another look?

@AlMcKinlay
Copy link
Contributor Author

Ah yes, sorry. I didn't notice that the colours weren't working. It was always showing colours for nicknames. I've fixed that now. Everything in #chat that was using a button is now also using .user. Should be good now.

@xPaw
Copy link
Contributor

xPaw commented Jan 24, 2016

By the way, user.tpl uses <button> for users too, should be changed?

@AlMcKinlay
Copy link
Contributor Author

Well, I think it's unlikely people are going to copy the list of users, but I'm happy to change that as well, if people want. Need to rebase now anyway, thanks to @erming merging so much today :-P

@AlMcKinlay
Copy link
Contributor Author

I think this should be good now, assuming that no one thinks there's a need to ensure the user list is copy-able.

@JocelynDelalande
Copy link
Collaborator

reviewed and tested, that's a 👍 for me.

@astorije
Copy link
Collaborator

👍

astorije added a commit that referenced this pull request Jan 26, 2016
Change user buttons to as. Allows highlighting on firefox.
@astorije astorije merged commit 3b55229 into erming:master Jan 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants