This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Simply parse all 0-99 irc colors #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erming
added a commit
that referenced
this pull request
Jan 24, 2016
Simply parse all 0-99 irc colors
|
Not even a chance to look at it, nice. |
| @@ -56,8 +56,8 @@ function uri(text) { | |||
| * https://github.com/megawac/irc-style-parser/tree/shout | |||
| */ | |||
| var styleCheck_Re = /[\x00-\x1F]/, | |||
| back_re = /^(\d{1,2})(,(\d{1,2}))?/, | |||
| colourKey = "\x03", colour_re = /\x03/g, | |||
| back_re = /^([0-9]{1,2})(,([0-9]{1,2}))?/, | |||
There was a problem hiding this comment.
Why replacing \d with [0-9]? Aren't they the same?
There was a problem hiding this comment.
They are not. http://stackoverflow.com/a/6479605/2200891
There was a problem hiding this comment.
Waouh, I'd pretend I didn't know that, but I also see I +1ed this answer more than 2 years ago :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a couple of things:
colourMaparray