Fix cache_adjust_FileAlignment to work with files not aligned to 0x200 #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This did send me down quite a rabbit hole. It turns out that, for all I can see, Windows ignores the header's |
erocarrera
added a commit
that referenced
this pull request
Apr 19, 2024
PR #397 led me to revisit the Window's loader behavior. It appears to ignore FileAlignment and always round the PointerToRawData to the sector size (512 bytes).
|
@erocarrera I understand what you mean. If you wish, I can provide you a copy of the file in question. |
|
Hi @asivery , yes please, that'd be great! |
|
@erocarrera Sorry for the delay, here you go: salwrap.zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please let me know if this isn't a bug, but the library definitely doesn't align PE files aligned to 0x1000 correctly, and this did fix that.
Best regards.