Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed lua regression and application launcher issues and made a new keyboard layout widget #207

Open
wants to merge 77 commits into
base: master
Choose a base branch
from

Conversation

frostedpenguin
Copy link

the repo had issues rendering the panels with lua 5.4. This was due to changes to the require function which are explained in this issue 3563. I fixed the underlined problems and it seems to work fine, except the today panel which needs further investigation. I also fixed the problems with the appearance of the application launcher and made a brand new widget that indicates the current keyboard layout used based on xkb signals

image
image
image

@Myp3a
Copy link

Myp3a commented Jul 23, 2022

I've got the problem with the panels. There is no need for the indexes - they turn panels into a nil.
If you define the widgets before adding them to the return function - they work fine for some reason.

Here is the patch with:

  • Panel fixes - they are showing correct data now
  • Audio widget transition to PulseAudio - now, when the Arch has moved to the Pipewire, ALSA controls aren't reliable, they are usually set to 100%. This implementation changes the volume of default Pipewire sink, as it should in modern systems.

patch.txt

@frostedpenguin
Copy link
Author

@Myp3a you were right even though indexing the require() would not produce errors the widget would not render properly. Therefore I changed my commit and now the right panel is working fine too!

@cursome
Copy link

cursome commented Sep 18, 2022

Hey @frostedpenguin ,
Surreal Isn't working anymore.
And please open a issue section in your fork, if possible add a contact way in your profile. I couldn't find any way to contact you so need to post my comment here. Please fix surreal in your fork.

Also the search button's rofi in gnawsome not working .. Expecting it as you showed up in your screenshot.

Screenshot_2022-09-19_00-42-46

@frostedpenguin
Copy link
Author

Hi @cursome I forgot to pass the global fixes from my config to the fork now I did and it works as expected. Thanks for the suggestions I have just applied them now if you have any more remarks you can create an issue or contact me!

@ildar
Copy link

ildar commented Mar 24, 2023

I love your changes. especially uniting configurations. This allows avoiding the error-prone copying.

@frostedpenguin
Copy link
Author

@ildar cheers man hope one day it gets merged 🤣. In this point I feel there isn't any use on further building it if I don't have a solid stream of feedback and issues!

@ThinhNguyenHoang1
Copy link

ThinhNguyenHoang1 commented Sep 1, 2023

@frostedpenguin , I just want to drop by and say "Thank you so much"

After weekends of unending digging and configuring stuffs to fix broken things when following the README.MD, your fork is a complete savior for me 😄

@frostedpenguin
Copy link
Author

@ThinhNguyenHoang1 Glad I could help 😋

@mohamadali-halwani
Copy link

any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants