Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove built-in slack backend #1581

Merged
merged 10 commits into from
Jul 21, 2022
Merged

Conversation

sijis
Copy link
Contributor

@sijis sijis commented Jun 20, 2022

Remove built-in (deprecated) slack backends in favor of slackv3.

@sijis sijis force-pushed the refactor/slack branch 3 times, most recently from dd3fcd8 to f8355cc Compare June 21, 2022 00:09
@sijis sijis requested a review from nzlosh June 22, 2022 03:42
@sijis sijis marked this pull request as ready for review June 22, 2022 03:42
@sijis
Copy link
Contributor Author

sijis commented Jun 22, 2022

@nzlosh Could you look over slack documentation and make sure it looks right?

Copy link
Contributor

@nzlosh nzlosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@sijis sijis merged commit b1a6408 into errbotio:master Jul 21, 2022
@sijis sijis deleted the refactor/slack branch July 21, 2022 03:04
sijis added a commit to sijis/errbot that referenced this pull request Jan 1, 2024
* refactor: remove slack backend

* refactor: remove slack-rtm backend

* test: remove slack tests

* docs: remove slack and use slackv3

* chore: add slackv3 build to Dockerfile

* feat: enable backend plugins directory on --init

* chore: add slackv3 repo to backend image

* refactor: simplify the final image

* docs: fix slack refs in README

* docs: add info to CHANGES
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants