Issue #22 - Handle substrings and repetitions correctly in replacePaths #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n replacePaths Sort strings so longer strings are handled first, so the longer paths aren't mistakenly given a hash of some shorter substring path. Add global flag to replacePaths regex to ensure all instances of a path are handled.
|
LGTM from a quick look, I'll wait a bit for @rakeshpai to chime in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort strings so longer strings are handled first, so the longer
paths aren't mistakenly given a hash of some shorter substring path.
Add global flag to replacePaths regex to ensure all instances of a path
are handled.
Fixes #22.