Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with ersilia fetch from github inside a docker container #1193

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix bug with ersilia fetch from github inside a docker container #1193

merged 1 commit into from
Jul 9, 2024

Conversation

DhanshreeA
Copy link
Contributor

@DhanshreeA DhanshreeA commented Jul 9, 2024 •
edited
Loading

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

This PR fixes model fetch from Ersilia using github especially when it is in a Docker container.

Changes made
Moved docker client init from SimpleDocker init to where it is actually needed to be used (ie in the get_container method).

Closes #1192

@DhanshreeA DhanshreeA merged commit 702aae8 into master Jul 9, 2024
20 checks passed
@DhanshreeA DhanshreeA deleted the 1192-bug-ersilia-fetch-breaking-especially-when-inside-docker-containers branch July 9, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Ersilia Model Hub
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Ersilia fetch breaking especially when inside docker containers
1 participant
@DhanshreeA