Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflecting correct values in Model information file #1204

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

Malikbadmus
Copy link
Contributor

@Malikbadmus Malikbadmus commented Jul 19, 2024

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

For models that are fetched from docker, they have their information file being copied from the container storage to the host machine, this might lead to some incorrect data schema as the file being copied is a representation of the model environment inside the container and not the one on the host machine.

Changes to be made

Added a modify_information method to docker functionality, to modify the content of what is being copied from docker container.

Status

The information file now reflects the correct service class and size for model's fetched from DockerHub.

information.json

To do

Include model source value to model information file copied from container storage.

Related to #1196

@Malikbadmus Malikbadmus mentioned this pull request Jul 21, 2024
3 tasks
@DhanshreeA DhanshreeA merged commit 0b1b256 into ersilia-os:master Jul 22, 2024
16 checks passed
@Malikbadmus Malikbadmus deleted the correct_values branch July 22, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants