Reflecting correct values in Model information file #1204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Description
For models that are fetched from docker, they have their information file being copied from the container storage to the host machine, this might lead to some incorrect data schema as the file being copied is a representation of the model environment inside the container and not the one on the host machine.
Changes to be made
Added a modify_information method to docker functionality, to modify the content of what is being copied from docker container.
Status
The information file now reflects the correct service class and size for model's fetched from DockerHub.
information.json
To do
Include model source value to model information file copied from container storage.
Related to #1196