- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of Ersilia current command #1284
Conversation
Hi @DhanshreeA This is the main pull request. I have initially created a pull request yesterday for this same task. Can i go ahead of close the previous pull request #1282 ? CC @GemmaTuron |
hi @Ajoke23 isn't this a duplicate PR to the one you previously opened? |
Yes, it's. This is the pull request I want @DhanshreeA to go through because I created a new branch name |
Welldone @Ajoke23, next time you can just rename the branch from github. Here's a detailed explanation on how to go about it |
@Ajoke23 You can also run the |
Delete the current.py file since it's not needed
Hi @dzumii I posted the output after changes was made above. Incase you might have missed that, please I have attached the link below for your view: |
@DhanshreeA I have tested and reviewed this PR and I think this is good to go |
@Ajoke23 in the screen shot you have shared, it seems you are not running the |
Hi @DhanshreeA that was a typo error. I ran it again correctly by running
|
@Ajoke23 you should pull the merged changes so as to avoid conflicts, also @DhanshreeA I've ran the test and her changes are in good standing ready to be merged:) |
Hi @P-Mefut I have the changes pulled since I saw it. |
Okay great @Ajoke23, your work ready to be merged then... I've ran the test and it's in good standing... |
Thanks a lot. @dzumii also tested it too and it was also successful. I am sure @DhanshreeA will merge it soonest, I believe so. |
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Description
Remove/De-register the ersilia current command. The main aim is to make sure that when anyone run
ersilia current
it would return the error belowChanges to be made
Status
current
commandersilia current
locally (using codespace) and got the following output below:output.log
Is this pull request related to any open issue? If yes, replace issueID below with the issue ID
Related to #1267