-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged card command with catalog. #1264 #1285
Conversation
@teddyCodex , you can go ahead and deregister the card command in cmd.py and remove the card.py file. |
@DhanshreeA , I've reviewed the PR and suggested a few changes. I've also tested the code, and everything is working as expected. It looks good to be merged. |
Noted @Malikbadmus Will do so shortly. |
Thanks @Malikbadmus and @teddyCodex ! |
@Malikbadmus @DhanshreeA done and pushed. |
@teddyCodex this generally looks good, requesting some code cleanliness changes. |
- Changed the '--card' option to a flag with a default value of 'False'. - Added 'model' as a positional argument to the 'catalog' command and made it optional. - Implemented logic to handle the case where 'card' is provided without a 'model'. - Added error handling to notify user if no metadata is found for the specified model when using the 'card' flag.
Hi @DhanshreeA All changes implemented.
|
Hi @Malikbadmus @DhanshreeA had a chance to give this another look? |
Fantastic work, thanks @teddyCodex! |
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Description
Merged card command with catalog command while disabled existing ersilia card command.
This would allow a user add an optional --card flag to the catalog command enabling them view metadata about the particular model card requested.
The catalog command should still work as expected (without the --card flag)- providing a list of all available models in the Model Hub
Status
Commented out card.cmd to disable existing card command.
Implemented new card flag in catalog.py and updated catalog function to use the card command.
Removed unused ModelSearcher Class.
Is this pull request related to any open issue? If yes, replace issueID below with the issue ID
Closes #1264