-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-register api command from Ersilia CLI #1289
Conversation
I look forward to your feedback @DhanshreeA . Thank you for your time |
hi @adebisi4145, if your removing the command, shouldn't the command file |
Hello @P-Mefut , I'm currently working on that and trying to decide whether I should remove the |
237c1ab
to
cdd261d
Compare
Well if the command is no longer required then it's best to remove the api.py file... but I prefer we wait on @DhanshreeA to shed more light on it!!! |
Exactly, thanks @P-Mefut. Please take care of this @adebisi4145 :) Thank you for your inputs, both. |
@@ -1,49 +0,0 @@ | |||
import click |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the file entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @DhanshreeA for the feedback, this has now been done
Duly note @DhanshreeA , working on that immediately |
Great work @adebisi4145 . @DhanshreeA , I've reviewed and ran several tests, and this works as intended. |
Thank you @Malikbadmus for taking the time to review and test my code |
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Description
There's a command line
api
in Ersilia that calls different APIs likerun
,calculate
and so on. Ersilia no longer allow this, so the command is deprecated and needs to be deleted from Ersilia CLIChanges to be made
api
command from thecreate_cli.py
scriptersilia run
command.ersilia api run...
and that there's an error messageStatus
ersilia api run
hereDeregisterApi
and switched to itcmd.api()
command from thecreate_cli.py
script hereersilia run
command.ersilia api run...
, the CLI did not crash and I also got an error message hereIs this pull request related to any open issue? If yes, replace issueID below with the issue ID
Related to #1263