Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing PyAirtable dependency (#1259) #1291

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

daud99
Copy link
Contributor

@daud99 daud99 commented Oct 4, 2024

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

Replace this line with a short description here...

Changes to be made

Replace this line with how do you intend to go about getting this done...

Status

Replace this line with what you have done so far...

To do

If this is a work in progress, Replace this line with your next steps

Is this pull request related to any open issue? If yes, replace issueID below with the issue ID
Closes #1259

ersilia/hub/fetch/fetch.py Outdated Show resolved Hide resolved
@Malikbadmus
Copy link
Contributor

Reviewed this PR and ran several tests. LGTM!

@DhanshreeA
Copy link
Member

@daud99 there's a test failing. Could you inspect and update here?

@daud99
Copy link
Contributor Author

daud99 commented Oct 8, 2024

@DhanshreeA Okay I'm checking it.

@daud99
Copy link
Contributor Author

daud99 commented Oct 8, 2024

@DhanshreeA

The test failure is happening because we've hit GitHub's hourly API request limit. The code is fine - we just need to wait for the rate limit to reset and run the test again.

The error shows this clearly:

403 Client Error: rate limit exceeded for url: https://api.github.com/users/ersilia-os/repos

@DhanshreeA DhanshreeA merged commit 43bbe1d into ersilia-os:master Oct 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐈 Task: Ersilia still trying to use Airtable while deciding how to fetch a model
3 participants