Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the api command from the Circleci workflow #1305

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Removed the api command from the Circleci workflow #1305

merged 5 commits into from
Oct 10, 2024

Conversation

mercybassey
Copy link
Contributor

@mercybassey mercybassey commented Oct 9, 2024

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

The api command in Ersilia is deprecated; therefore, any workflow that uses it will fail.

Changes to be made

This PR aims to remove the api command from the Circle CI workflow.

Status

This PR removes the api command from the Circle CI workflow.

Is this pull request related to any open issue? If yes, replace issueID below with the issue ID

Closes #1303

@mercybassey
Copy link
Contributor Author

Hello @DhanshreeA this PR is ready for review. Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mercybassey we actually need to use the run command, instead of the api command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I'll fix it

@mercybassey
Copy link
Contributor Author

@DhanshreeA I have added the run command instead. Thanks.

@DhanshreeA DhanshreeA merged commit 8788c49 into ersilia-os:master Oct 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐈 Task: Update Circle CI test script to remove deprecated api.
2 participants