Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nci_smiles_to_inchikey test #1338

Closed
wants to merge 2 commits into from

Conversation

tongyu0924
Copy link
Contributor

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description
This pull request adds new positive and negative tests for the _nci_smiles_to_inchikey function of the CompoundIdentifier class. These tests mock successful and failed API responses to ensure the function behaves correctly under different conditions.

Changes to be made

  1. Added two new tests:
    • test_nci_smiles_to_inchikey_positive for valid SMILES to InChIKey conversion.
    • test_nci_smiles_to_inchikey_negative to test handling of invalid SMILES input with a 404 response.
  2. Used @patch to mock API calls to ensure the tests don't rely on external dependencies.

Status

Replace this line with what you have done so far...

To do

If this is a work in progress, Replace this line with your next steps

Is this pull request related to any open issue? If yes, replace issueID below with the issue ID

Related to #1319

@DhanshreeA
Copy link
Contributor

Closing this PR as redundant since these tests have already been merged.

@DhanshreeA DhanshreeA closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants