Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Description
This pull request adds new positive and negative tests for the
_nci_smiles_to_inchikey
function of theCompoundIdentifier
class. These tests mock successful and failed API responses to ensure the function behaves correctly under different conditions.Changes to be made
test_nci_smiles_to_inchikey_positive
for valid SMILES to InChIKey conversion.test_nci_smiles_to_inchikey_negative
to test handling of invalid SMILES input with a 404 response.@patch
to mock API calls to ensure the tests don't rely on external dependencies.Status
Replace this line with what you have done so far...
To do
If this is a work in progress, Replace this line with your next steps
Is this pull request related to any open issue? If yes, replace issueID below with the issue ID
Related to #1319