Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Catalog command #1426

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Refactor Catalog command #1426

merged 3 commits into from
Dec 12, 2024

Conversation

DhanshreeA
Copy link
Contributor

@DhanshreeA DhanshreeA commented Dec 10, 2024

This PR introduces more changes to make the catalog command simpler:

  • Catalog command should show a table by default. Consolidate --as-table / --as-json option.
  • Catalog command should show the identifier and slug by default when the --more option is not used
  • Catalog --browser eliminate and consolidate --local/--hub
  • Harmonize the --more flag: Identifier, Slug, Title, Task, Input shape, Output, Output shape, Model source (if local)
  • Sort models by ID
  • Index in the table to know how many models are there

@DhanshreeA DhanshreeA marked this pull request as draft December 10, 2024 11:29
@DhanshreeA DhanshreeA force-pushed the fix/refactor-catalog-cmd branch from 9c39d65 to f45d4cd Compare December 10, 2024 11:50
@DhanshreeA DhanshreeA marked this pull request as ready for review December 12, 2024 05:57
Abellegese and others added 3 commits December 12, 2024 11:29
* Update config.yml - fix Circle CI pipeline

* Playground Implementation

* Playground Implementation

* Support CLI batching, and more

* Update CLI test

* Update CLI test

* Update CLI test

* CLI test Update

* A few fix on the playground test

* A few fix on the playground test

* A few fix on the playground test

* Playground with all command at #1368

* Playground with all command at #1368

* Playground with all command at #1368

* Playground with all command at #1368

* Playground with all command at #1368

* Playground with all command at #1368

* Session Parallelization on CLI test playground

* Session Parallelization on CLI test playground

* Session Parallelization on CLI test playground

* Session Parallelization on CLI test playground

* Session Parallelization on CLI test playground

* Session Parallelization on CLI test playground

* Session Parallelization on CLI test playground

* Session Parallelization on CLI test playground

* Session Parallelization on CLI test playground

* Session Parallelization on CLI test playground

* Session Parallelization on CLI test playground

* Session Parallelization on CLI test playground

* Session Parallelization on CLI test playground

* Session Parallelization on CLI test playground with pytest dependency

* Rich lib integration pyproject config

* Make the serializer use the fields from the header (#1406)

* Generalize Standard Run  (#1411)

* Modify header calculation to choose from predefined example output file or standard example output file

* Remove the readiness function from SCRA because it is redundant, since those checks are also performed by the amenable function

* Remove unused method

* Make csv serialization work for any kind of model api response

* Remove the standard flag from the CLI since it is now the default run

* Update tests

* Creating python for Nox sessions

* Creating python for Nox sessions

* Generalize Standard Run  (#1411)

* Modify header calculation to choose from predefined example output file or standard example output file

* Remove the readiness function from SCRA because it is redundant, since those checks are also performed by the amenable function

* Remove unused method

* Make csv serialization work for any kind of model api response

* Remove the standard flag from the CLI since it is now the default run

* Update tests

* Generalize Standard Run  (#1411)

* Modify header calculation to choose from predefined example output file or standard example output file

* Remove the readiness function from SCRA because it is redundant, since those checks are also performed by the amenable function

* Remove unused method

* Make csv serialization work for any kind of model api response

* Remove the standard flag from the CLI since it is now the default run

* Update tests

* Make the serializer use the fields from the header (#1406)

* Merge sample command with the example command (#1422)

* Merge sample command with the example command

* Fix example command usage

* Generalize Standard Run  (#1411)

* Modify header calculation to choose from predefined example output file or standard example output file

* Remove the readiness function from SCRA because it is redundant, since those checks are also performed by the amenable function

* Remove unused method

* Make csv serialization work for any kind of model api response

* Remove the standard flag from the CLI since it is now the default run

* Update tests

* Conflict resolved with upstream

* Conflict resolved with upstream

* Generalize Standard Run  (#1411)

* Modify header calculation to choose from predefined example output file or standard example output file

* Remove the readiness function from SCRA because it is redundant, since those checks are also performed by the amenable function

* Remove unused method

* Make csv serialization work for any kind of model api response

* Remove the standard flag from the CLI since it is now the default run

* Update tests

* Make the serializer use the fields from the header (#1406)

* Generalize Standard Run  (#1411)

* Modify header calculation to choose from predefined example output file or standard example output file

* Remove the readiness function from SCRA because it is redundant, since those checks are also performed by the amenable function

* Remove unused method

* Make csv serialization work for any kind of model api response

* Remove the standard flag from the CLI since it is now the default run

* Update tests

* Conflict resolved with upstream

* Conflict resolved with upstream

* Unnecessary files removed

* Generalize Standard Run  (#1411)

* Modify header calculation to choose from predefined example output file or standard example output file

* Remove the readiness function from SCRA because it is redundant, since those checks are also performed by the amenable function

* Remove unused method

* Make csv serialization work for any kind of model api response

* Remove the standard flag from the CLI since it is now the default run

* Update tests

* Unnecessary files removed

* Generalize Standard Run  (#1411)

* Modify header calculation to choose from predefined example output file or standard example output file

* Remove the readiness function from SCRA because it is redundant, since those checks are also performed by the amenable function

* Remove unused method

* Make csv serialization work for any kind of model api response

* Remove the standard flag from the CLI since it is now the default run

* Update tests

* Make the serializer use the fields from the header (#1406)

* Unnecessary files removed

* Unnecessary files removed

* Unnecessary files removed

* Unnecessary files removed

* Fix: Unnecessary files removed

---------

Co-authored-by: Dhanshree Arora <DhanshreeA@users.noreply.github.com>
@DhanshreeA DhanshreeA force-pushed the fix/refactor-catalog-cmd branch from fa44e64 to 480a600 Compare December 12, 2024 05:59
@DhanshreeA DhanshreeA merged commit 5f7c6ef into master Dec 12, 2024
27 checks passed
@DhanshreeA DhanshreeA deleted the fix/refactor-catalog-cmd branch December 12, 2024 06:07
@DhanshreeA DhanshreeA mentioned this pull request Dec 12, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants