Make Ersilia exit when trying to delete a model fetched using docker if Docker is not active

ersilia/cli/commands/delete.py

@@ -31,10 +31,13 @@ def delete_cmd():
         Delete all models:
         $ ersilia delete --all
     """
+    def _delete(md, model_id):
+        md.delete(model_id)
 
     def _delete_model_by_id(model_id):
         md = ModelFullDeleter()
-        if md.needs_delete(model_id):
+        can_delete, reason = md.can_be_deleted(model_id)
+        if can_delete:
             echo("Deleting model {0}".format(model_id))
             _delete(md, model_id)
             echo(
@@ -43,15 +46,12 @@ def _delete_model_by_id(model_id):
             )
         else:
             echo(
-                ":person_tipping_hand: Model {0} is not available locally. No delete is necessary".format(
+                f":person_tipping_hand: {reason}".format(
                     model_id
                 ),
                 fg="yellow",
             )
 
-    def _delete(md, model_id):
-        md.delete(model_id)
-
     def _delete_all():
         """Function to delete all locally available models"""
         model_catalog = ModelCatalog()

ersilia/hub/delete/delete.py

@@ -1,12 +1,14 @@
 import os
 import shutil
 import os.path
+from typing import Tuple
 from ... import ErsiliaBase
 from ...utils.terminal import run_command
 from ...utils.environment import Environment
 from ...utils.conda import SimpleConda
 from ...utils.system import is_inside_docker
 from ..content.catalog import ModelCatalog
+from ..content.card import ModelCard
 from ...db.environments.localdb import EnvironmentDb
 from ...db.hubdata.localslugs import SlugDb
 from ...db.environments.managers import DockerManager
@@ -450,7 +452,7 @@ def delete(self, model_id: str):
             )
         )
         dm = DockerManager(config_json=self.config_json)
-        if dm.is_active():
+        if dm.is_active(): # TODO This is hacky but is needed by ModelPreparer when model is fetched. 
             dm.delete_images(model_id)
 
 
@@ -535,7 +537,7 @@ def __init__(self, config_json=None, overwrite=True):
         self.overwrite = overwrite
         ErsiliaBase.__init__(self, config_json=config_json, credentials_json=None)
 
-    def needs_delete(self, model_id: str) -> bool:
+    def _needs_delete(self, model_id: str) -> bool:
         """
         Checks if the model needs to be deleted.
 
@@ -557,6 +559,31 @@ def needs_delete(self, model_id: str) -> bool:
             return True
         return False
 
+    def can_be_deleted(self, model_id: str) -> Tuple[bool, str]:
+        """
+        Checks if the model can be deleted.
+
+        Parameters
+        ----------
+        model_id : str
+            Identifier of the model.
+
+        Returns
+        -------
+        bool
+            True if the model can be deleted, False otherwise.
+        """
+        needs_delete = self._needs_delete(model_id)
+        mc = ModelCard(config_json=self.config_json).get(model_id)
+        model_source = ModelCatalog(config_json=self.config_json)._get_model_source(mc)
+        dm = DockerManager(config_json=self.config_json)
+        if needs_delete:
+            if model_source == "DockerHub" and not dm.is_active():
+                return False, "Model fetched through Docker but Docker engine is inactive."
+            return True, "Model can be deleted."
+        else:
+            return False, f"Model {model_id} is not available locally, no delete necessary."
+
     def delete(self, model_id: str):
         """
         Deletes all data related to the model.