Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing inspect service skipping few remote checks #1460

Merged

Conversation

Abellegese
Copy link
Contributor

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

Fix #1459

Abellegese and others added 9 commits December 17, 2024 19:14
* Merge sample command with the example command

* Fix example command usage
* Modify header calculation to choose from predefined example output file or standard example output file

* Remove the readiness function from SCRA because it is redundant, since those checks are also performed by the amenable function

* Remove unused method

* Make csv serialization work for any kind of model api response

* Remove the standard flag from the CLI since it is now the default run

* Update tests
@Abellegese Abellegese changed the title Fixing inspect service skipping checks fixes Fixing inspect service skipping few remote checks Dec 17, 2024
@DhanshreeA DhanshreeA force-pushed the master branch 5 times, most recently from 143ebdf to e896fd1 Compare December 17, 2024 21:51
@DhanshreeA DhanshreeA merged commit 994ba44 into ersilia-os:master Dec 19, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Incorrect Variable Used in InspectService class Causing Skipped Few Remote Checks
2 participants